Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C library: ASM functions take void* pointers #7932

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

tautschnig
Copy link
Collaborator

This is the type of the function symbol created by remove_asmt::gcc_asm_function_call.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19fc213) 79.69% compared to head (0fff131) 79.69%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7932   +/-   ##
========================================
  Coverage    79.69%   79.69%           
========================================
  Files         1680     1680           
  Lines       195202   195204    +2     
========================================
+ Hits        155571   155573    +2     
  Misses       39631    39631           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tautschnig and others added 3 commits January 24, 2024 11:55
This is the type of the function symbol created by
`remove_asmt::gcc_asm_function_call`.
An inline asm statement may include multiple commands that take a
varying number of inputs or outputs. When we replace a command by a
function call, we need to use the correct number of arguments.

Fixes: diffblue#8165
Signed-off-by: Norbert Manthey <[email protected]>
@tautschnig tautschnig requested a review from a team as a code owner January 24, 2024 12:47
@tautschnig tautschnig merged commit c81a6a6 into diffblue:develop Feb 8, 2024
39 checks passed
@tautschnig tautschnig deleted the cleanup/asm-library branch February 8, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants