Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C front-end: typecheck conditional operator over string literal and 0 #7946

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

tautschnig
Copy link
Collaborator

0 is a valid null-pointer constant, even in the absence of an explicit type cast.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Sorry, something went wrong.

@tautschnig tautschnig self-assigned this Oct 12, 2023
@tautschnig tautschnig removed their assignment Oct 13, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.31%. Comparing base (8646bfa) to head (0f14879).
Report is 4 commits behind head on develop.

Files Patch % Lines
src/ansi-c/c_typecheck_expr.cpp 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7946      +/-   ##
===========================================
- Coverage    78.37%   78.31%   -0.07%     
===========================================
  Files         1726     1726              
  Lines       188322   188477     +155     
  Branches     18460    18441      -19     
===========================================
+ Hits        147606   147611       +5     
- Misses       40716    40866     +150     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening
Copy link
Member

We may wish to have a function or method for the decay of the string literal type.

@tautschnig tautschnig assigned tautschnig and unassigned kroening Jun 17, 2024
0 is a valid null-pointer constant, even in the absence of an explicit
type cast.
@tautschnig tautschnig merged commit f75a90a into diffblue:develop Jun 18, 2024
39 of 40 checks passed
@tautschnig tautschnig deleted the bugfixes/null-ptr branch June 18, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants