[CI] Minor fixes to CI accompanying C++17 version change #8028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8028 +/- ##
========================================
Coverage 79.10% 79.10%
========================================
Files 1699 1699
Lines 196508 196508
========================================
+ Hits 155443 155446 +3
+ Misses 41065 41062 -3 ☔ View full report in Codecov by Sentry. |
…with C++17 move.
…rn matching during build.
NlightNFotis
force-pushed
the
fix_rust_ci
branch
from
33baf18 to
b87d442
Compare
tautschnig
approved these changes
Nov 14, 2023
Python warns about the use of `\d`: we should use raw strings here as that's not meant to be an escape sequence.
See https://github.com/diffblue/cbmc/actions/runs/6856483568/job/18643716705?pr=6749 for one example of the failure: cargo-induced clang runs (via the cc crate) weren't finding the C++ library (which ought to be libc++ and not libstdc++ on this MacOS target). This appears to be caused by the minimum build target being too low (where the cc crate is the one setting that minimum). Override that by setting an environment variable. See https://github.com/rust-lang/cc-rs/blob/2d6a3b2119cf5eacc01e1f2877e064a7aede7819/src/lib.rs#L3497C52-L3497C76 for the Rust code implementing the logic.
The prefix lookup resulted in picking up the Release-Glucose cache from check-macos-12-cmake-clang. This cache, however, was established with Glucose as a SAT solver, which implies different compiler command lines. Consequently, there would be 0 cache hits.
NlightNFotis
force-pushed
the
fix_rust_ci
branch
from
9862f64 to
5f0d5df
Compare
NlightNFotis
requested review from
a team,
thomasspriggs,
TGWDB,
peterschrammel and
esteffin
as code owners
esteffin
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Rust API build for macOS when running on
developis failing, with the toolchain saying that it cannot find the file for<algorithm>. This points to a stale or otherwise compromised build configuration, so this is an experimental PR to change the environment (macOS) to a newer version (12 -> 13) in an attempt to ameliorate the situation.