Assignments to bit-fields yield results of bit-field type #8082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
added
C Front End
soundness
tautschnig
force-pushed
the
bugfixes/bit-fields
branch
from
0aacbe4 to
ed713ff
Compare
tautschnig
requested review from
martin-cs,
peterschrammel,
kroening and
remi-delmas-3000
as code owners
peterschrammel
approved these changes
Dec 14, 2023
| // the result is the declared width (rounded to bytes), all others use the | ||
| // size of the underlying type. | ||
| // https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2958.htm | ||
| // for a discussion that this isn't actually specified (while being a |
There was a problem hiding this comment.
(Still GCC's interpretation makes considerably more sense than the others'.)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #8082 +/- ##
========================================
Coverage 79.08% 79.08%
========================================
Files 1698 1698
Lines 196465 196491 +26
========================================
+ Hits 155380 155401 +21
- Misses 41085 41090 +5 ☔ View full report in Codecov by Sentry. |
goto-program conversion may introduce temporaries of c_bit_field type. These, however, are not permitted outside structs in C. Instead, change their types to their underlying types and use a bit mask to fix up initial values.
Do not pre-emptively cast side effects over bit-fields to the underlying type. sizeof just has a very peculiar semantics, which is discussed in https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2958.htm. Issue was found by CSmith (test generated with random seed 1700653858).
tautschnig
force-pushed
the
bugfixes/bit-fields
branch
from
ed713ff to
16c0cbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not pre-emptively cast side effects over bit-fields to the underlying type. sizeof just has a very peculiar semantics, which is discussed in https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2958.htm.
Issue was found by CSmith (test generated with random seed 1700653858).