Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix conversions between long and long long #8086

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

kroening
Copy link
Member

as_long in external_sat.cpp was declared as long long, computed as long, and subsequently passed to labs, which expects a long. This yields an error on any platform where long is not long long.

This changes the calculation to use long long consistently.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

as_long in external_sat.cpp was declared as long long, computed as long, and
subsequently passed to labs, which expects a long.  This yields an error on
any platform where long is not long long.

This changes the calculation to use long long consistently.
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52688d7) 79.09% compared to head (8db67b9) 79.09%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8086   +/-   ##
========================================
  Coverage    79.09%   79.09%           
========================================
  Files         1701     1701           
  Lines       196625   196625           
========================================
  Hits        155527   155527           
  Misses       41098    41098           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening merged commit 9061084 into develop Nov 27, 2023
@kroening kroening deleted the external_sat_llabs branch November 27, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants