Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the STL versions of variant and optional in incremental smt2 decision procedure #8089

Merged
merged 8 commits into from
Nov 29, 2023

Conversation

thomasspriggs
Copy link
Contributor

This PR updates the incremental smt2 decision procedure to use the STL versions of variant and optional.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6475b3c) 79.09% compared to head (062d6c6) 79.09%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8089      +/-   ##
===========================================
- Coverage    79.09%   79.09%   -0.01%     
===========================================
  Files         1700     1700              
  Lines       196619   196617       -2     
===========================================
- Hits        155521   155519       -2     
  Misses       41098    41098              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasspriggs thomasspriggs marked this pull request as ready for review November 28, 2023 19:56
@thomasspriggs thomasspriggs merged commit 10d922c into diffblue:develop Nov 29, 2023
@thomasspriggs thomasspriggs deleted the tas/smt_stl branch November 29, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants