Code contracts: do not interleave checking and instrumenting #8095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
feliperodri and
remi-delmas-3000
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #8095 +/- ##
===========================================
- Coverage 79.69% 79.69% -0.01%
===========================================
Files 1680 1680
Lines 195167 195195 +28
===========================================
+ Hits 155544 155564 +20
- Misses 39623 39631 +8 ☔ View full report in Codecov by Sentry. |
feliperodri
reviewed
Dec 5, 2023
tautschnig
force-pushed
the
bugfixes/contracts-loop-normalisation
branch
from
649dbb3 to
c9c23be
Compare
tautschnig
requested review from
martin-cs,
peterschrammel and
kroening
as code owners
feliperodri
approved these changes
Jan 15, 2024
peterschrammel
approved these changes
Jan 16, 2024
Maintain goto-program invariants when modifying a program via function-pointer restrictions.
tautschnig
force-pushed
the
bugfixes/contracts-loop-normalisation
branch
from
c9c23be to
98f41b0
Compare
Loop normalisation must first check that all loops described via `natural_loopst` are of the expected shape and then start inserting or transforming instructions. Else, and depending on loop shapes and loop nesting, the instruction iterators held in the `natural_loopst` may no longer be adequate descriptions of the loops. (The iterators weren't invalidated, but would no longer point to heads or loop ends.)
This is to use standard terminology.
tautschnig
force-pushed
the
bugfixes/contracts-loop-normalisation
branch
from
98f41b0 to
e2e3e0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loop normalisation must first check that all loops described via
natural_loopstare of the expected shape and then start inserting or transforming instructions. Else, and depending on loop shapes and loop nesting, the instruction iterators held in thenatural_loopstmay no longer be adequate descriptions of the loops. (The iterators weren't invalidated, but would no longer point to heads or loop ends.)