Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default messaget value from goto_program_dereferencet #8100

Merged

Conversation

tautschnig
Copy link
Collaborator

Use a message_handlert throughout, and firmly require that instead of using a default value (of a deprecated messaget()).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Use a message_handlert throughout, and firmly require that instead of
using a default value (of a deprecated messaget()).
@tautschnig tautschnig force-pushed the cleanup/dereference-messaget branch from 92c6cd5 to 18ab74b Compare December 13, 2023 12:29
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (6930101) 79.07% compared to head (18ab74b) 79.08%.
Report is 2 commits behind head on develop.

Files Patch % Lines
src/goto-diff/change_impact.cpp 0.00% 6 Missing ⚠️
.../goto-instrument/goto_instrument_parse_options.cpp 40.00% 6 Missing ⚠️
jbmc/src/jbmc/jbmc_parse_options.cpp 0.00% 2 Missing ⚠️
src/goto-instrument/full_slicer.cpp 71.42% 2 Missing ⚠️
src/goto-instrument/interrupt.cpp 0.00% 2 Missing ⚠️
src/goto-instrument/mmio.cpp 0.00% 2 Missing ⚠️
src/goto-instrument/rw_set.h 66.66% 2 Missing ⚠️
jbmc/src/janalyzer/janalyzer_parse_options.cpp 0.00% 1 Missing ⚠️
jbmc/src/jdiff/jdiff_parse_options.cpp 0.00% 1 Missing ⚠️
src/goto-diff/goto_diff_parse_options.cpp 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8100      +/-   ##
===========================================
+ Coverage    79.07%   79.08%   +0.01%     
===========================================
  Files         1698     1698              
  Lines       196457   196463       +6     
===========================================
+ Hits        155339   155377      +38     
+ Misses       41118    41086      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig assigned martin-cs and unassigned tautschnig Dec 13, 2023
Copy link
Collaborator

@feliperodri feliperodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes in the goto-instrument and goto-synthesizer modules LGTM.

@tautschnig tautschnig merged commit f663957 into diffblue:develop Dec 15, 2023
35 of 36 checks passed
@tautschnig tautschnig deleted the cleanup/dereference-messaget branch December 15, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants