Use malloc fail null by default #8101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasspriggs
added
the
Version 6
thomasspriggs
force-pushed
the
tas/default-malloc-failure
branch
from
1b30d51 to
f38c54a
Compare
thomasspriggs
force-pushed
the
tas/default-malloc-failure
branch
from
5ca8193 to
9ede58f
Compare
thomasspriggs
requested review from
martin-cs,
peterschrammel,
kroening,
tautschnig,
NlightNFotis,
jimgrundy and
TGWDB
as code owners
thomasspriggs
changed the title
thomasspriggs
force-pushed
the
tas/default-malloc-failure
branch
from
41c7eaf to
27c99d5
Compare
esteffin
approved these changes
Dec 15, 2023
thomasspriggs
force-pushed
the
tas/default-malloc-failure
branch
from
27c99d5 to
ed0acac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8101 +/- ##
========================================
Coverage 79.08% 79.08%
========================================
Files 1696 1697 +1
Lines 196429 196504 +75
========================================
+ Hits 155343 155405 +62
- Misses 41086 41099 +13 ☔ View full report in Codecov by Sentry. |
kroening
reviewed
Dec 15, 2023
regression/contracts-dfcc/chain.sh
Outdated
| @@ -43,6 +43,10 @@ else | |||
| $goto_cc -o "${name}${dfcc_suffix}.gb" "${name}.c" | |||
| fi | |||
|
|
|||
| if [[ "${args_inst}" != *"malloc"* ]]; then | |||
| args_inst="--no-malloc-fail $args_inst" | |||
There was a problem hiding this comment.
Please don't do that. It will be outrageously difficult to understand what tests actually do.
There was a problem hiding this comment.
Hi Daniel, we're handling this in a different PR (#8106) where we're reverting this change across all regression/ build files.
It would be preferable if we can merge this one with this change in, so that it's on par with the other build changes currently in develop, so that we can then track and remove all of them in #8106 instead of having some of them here and some there, increasing the chance of having some stale changes by accident.
kroening
reviewed
Dec 15, 2023
regression/goto-instrument/chain.sh
Outdated
| @@ -21,7 +21,7 @@ else | |||
| fi | |||
|
|
|||
| rm -f "${target}-mod.gb" | |||
| $goto_instrument ${args} "${target}.gb" "${target}-mod.gb" | |||
| $goto_instrument --no-malloc-fail ${args} "${target}.gb" "${target}-mod.gb" | |||
So that the malloc failure configuration can be returned to non failure, without using the full `--no-standard-checks` option.
The calls to the `set_default_analysis_flags` functions need to be before the call to `config.set(cmdline)` so that the malloc defaults can be set before being overridden by any command line specified malloc behaviour.
In order to keep existing tests passing.
esteffin
force-pushed
the
tas/default-malloc-failure
branch
from
ed0acac to
c3635b1
Compare
esteffin
force-pushed
the
tas/default-malloc-failure
branch
2 times, most recently
from
2ace435 to
4bcbc9d
Compare
esteffin
force-pushed
the
tas/default-malloc-failure
branch
from
4bcbc9d to
c3c7bc0
Compare
peterschrammel
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the defaults so that we use a model where malloc may fail with a null return value. This work is split from #8093 This change in the default avoids the possibility of memory allocations which overflow the size of the object bits.