Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep symbols as nondet rather than using their symbol table values in SMT decision procedure. #8104

Conversation

thomasspriggs
Copy link
Contributor

This PR keeps symbols as nondet rather than using their symbol table values in SMT decision procedure.
This is needed because the value of a symbol is not intended to be defined until it has been expressed via expressions explicitly passed to the decision procedure.

This should help with this PR - #7858

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64fe4d0) 79.07% compared to head (c3a910f) 79.08%.
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8104      +/-   ##
===========================================
+ Coverage    79.07%   79.08%   +0.01%     
===========================================
  Files         1698     1698              
  Lines       196464   196437      -27     
===========================================
+ Hits        155347   155349       +2     
+ Misses       41117    41088      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There now appear to be some includes that are no longer required.

Because the value of a symbol is not intended to be defined until
it has been expressed via expressions explicitly passed to the decision
procedure.
@thomasspriggs thomasspriggs force-pushed the tas/smt-no-implicit-symbol-values branch from 956afe4 to c3a910f Compare December 13, 2023 21:23
@thomasspriggs thomasspriggs merged commit 9459ea5 into diffblue:develop Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants