Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSmith test script: avoid a need for argv modelling #8105

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

tautschnig
Copy link
Collaborator

With additional checks turned on as of #8093, we failed CSmith tests with (legitimate) pointer property failures in strcmp. These are caused by trying to compare argv[1] to a string. As we do not model argv in these tests, argv[1] was not a valid pointer. This fix just removes the string comparison, which is only used for turning on/off debug output in test execution.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

With additional checks turned on as of diffblue#8093, we failed CSmith tests
with (legitimate) pointer property failures in `strcmp`. These are
caused by trying to compare `argv[1]` to a string. As we do not model
`argv` in these tests, `argv[1]` was not a valid pointer. This fix just
removes the string comparison, which is only used for turning on/off
debug output in test execution.
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41af31c) 79.08% compared to head (5fa37a3) 79.08%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8105   +/-   ##
========================================
  Coverage    79.08%   79.08%           
========================================
  Files         1698     1698           
  Lines       196465   196465           
========================================
  Hits        155380   155380           
  Misses       41085    41085           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig assigned tautschnig and unassigned TGWDB Dec 14, 2023
@tautschnig tautschnig merged commit 2e0fcc8 into diffblue:develop Dec 14, 2023
@tautschnig tautschnig deleted the bugfixes/csmith-bugfix branch December 14, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants