Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nondeterministic hex_trace test #8121

Merged
merged 1 commit into from
Dec 18, 2023
Merged

fix nondeterministic hex_trace test #8121

merged 1 commit into from
Dec 18, 2023

Conversation

kroening
Copy link
Member

The cbmc/hex_trace test pattern relies on a particular value (0) for an uninitialized local variable. This removes the pattern.

See
https://github.com/diffblue/cbmc/actions/runs/6672135313/job/18269948126?pr=7979 as an exemplar where this was triggered.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The cbmc/hex_trace test pattern relies on a particular value (0) for an
uninitialized local variable.  This removes the pattern.

See
https://github.com/diffblue/cbmc/actions/runs/6672135313/job/18269948126?pr=7979
as an exemplar where this was triggered.
@kroening kroening added the Tests label Dec 18, 2023
@kroening kroening marked this pull request as ready for review December 18, 2023 16:20
@kroening kroening enabled auto-merge December 18, 2023 16:28
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5341b44) 79.08% compared to head (39513a3) 79.08%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8121      +/-   ##
===========================================
- Coverage    79.08%   79.08%   -0.01%     
===========================================
  Files         1696     1696              
  Lines       196429   196429              
===========================================
- Hits        155346   155343       -3     
- Misses       41083    41086       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening merged commit 8fc41f3 into develop Dec 18, 2023
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants