Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ front-end: configure C++11+ syntax without ansi_c_parser object #8132

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

tautschnig
Copy link
Collaborator

There is no need to access the parser object when the same information is available directly from config.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

There is no need to access the parser object when the same information
is available directly from `config`.
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1068770) 79.08% compared to head (a8d21c7) 79.08%.

Files Patch % Lines
src/cpp/parse.cpp 76.92% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8132   +/-   ##
========================================
  Coverage    79.08%   79.08%           
========================================
  Files         1696     1696           
  Lines       196505   196505           
========================================
  Hits        155408   155408           
  Misses       41097    41097           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening merged commit 69bb2b6 into diffblue:develop Jan 11, 2024
38 of 39 checks passed
@tautschnig tautschnig deleted the cleanup/cpp-11-config branch January 11, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants