Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ansi_c_internal_additions independent of the parser object #8133

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

tautschnig
Copy link
Collaborator

Thread through a Boolean flag rather than relying on the parser object far away from the actual parser.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69bb2b6) 79.09% compared to head (6d4e0db) 79.09%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8133      +/-   ##
===========================================
- Coverage    79.09%   79.09%   -0.01%     
===========================================
  Files         1695     1695              
  Lines       196583   196588       +5     
===========================================
+ Hits        155496   155498       +2     
- Misses       41087    41090       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Thread through a Boolean flag rather than relying on the parser object
far away from the actual parser.
@peterschrammel peterschrammel removed their assignment Jan 30, 2024
@tautschnig tautschnig merged commit 608b7ea into diffblue:develop Feb 1, 2024
@tautschnig tautschnig deleted the cleanup/ts-config branch February 1, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants