Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit constructing parsert with a message handler #8134

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

tautschnig
Copy link
Collaborator

This is to provide a path to remove the long-deprecated messaget() constructor. Uses of this new constructor will be added in separate commits.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This is to provide a path to remove the long-deprecated messaget()
constructor. Uses of this new constructor will be added in separate
commits.
@tautschnig
Copy link
Collaborator Author

#8135 is a first example using this interface, further PRs will follow.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1068770) 79.08% compared to head (c33db82) 79.08%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8134   +/-   ##
========================================
  Coverage    79.08%   79.08%           
========================================
  Files         1696     1696           
  Lines       196505   196505           
========================================
  Hits        155408   155408           
  Misses       41097    41097           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening merged commit f0c2391 into diffblue:develop Dec 20, 2023
39 checks passed
@tautschnig tautschnig deleted the cleanup/parser-messaget-prep branch December 20, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants