Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assembler_parsert: construct with message handler #8139

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

tautschnig
Copy link
Collaborator

This both avoids an object of static lifetime as well as it fixes the (transitive) use of the deprecated messaget() constructor.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (69bb2b6) 79.09% compared to head (9495ab2) 79.09%.

Files Patch % Lines
src/assembler/assembler_parser.cpp 75.00% 2 Missing ⚠️
src/assembler/assembler_parser.h 66.66% 1 Missing ⚠️
src/cbmc/cbmc_parse_options.cpp 50.00% 1 Missing ⚠️
src/goto-analyzer/goto_analyzer_parse_options.cpp 50.00% 1 Missing ⚠️
src/goto-diff/goto_diff_parse_options.cpp 50.00% 1 Missing ⚠️
.../goto-instrument/goto_instrument_parse_options.cpp 66.66% 1 Missing ⚠️
src/goto-synthesizer/cegis_verifier.cpp 50.00% 1 Missing ⚠️
src/libcprover-cpp/api.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8139      +/-   ##
===========================================
- Coverage    79.09%   79.09%   -0.01%     
===========================================
  Files         1695     1695              
  Lines       196583   196586       +3     
===========================================
+ Hits        155496   155497       +1     
- Misses       41087    41089       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@feliperodri feliperodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tautschnig tautschnig force-pushed the cleanup/assembler_parsert branch 2 times, most recently from 17471e9 to 9fceab8 Compare January 9, 2024 11:10
This both avoids an object of static lifetime as well as it fixes the
(transitive) use of the deprecated messaget() constructor. The scanner
is now fully reentrant.
@tautschnig tautschnig force-pushed the cleanup/assembler_parsert branch from 9fceab8 to 9495ab2 Compare January 11, 2024 15:14
Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up.

@tautschnig tautschnig merged commit d333f3b into diffblue:develop Feb 6, 2024
37 of 39 checks passed
@tautschnig tautschnig deleted the cleanup/assembler_parsert branch February 6, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants