-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assembler_parsert: construct with message handler #8139
assembler_parsert: construct with message handler #8139
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #8139 +/- ##
===========================================
- Coverage 79.09% 79.09% -0.01%
===========================================
Files 1695 1695
Lines 196583 196586 +3
===========================================
+ Hits 155496 155497 +1
- Misses 41087 41089 +2 ☔ View full report in Codecov by Sentry. |
5bbad53
to
69d3df7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
17471e9
to
9fceab8
Compare
This both avoids an object of static lifetime as well as it fixes the (transitive) use of the deprecated messaget() constructor. The scanner is now fully reentrant.
9fceab8
to
9495ab2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clean up.
This both avoids an object of static lifetime as well as it fixes the (transitive) use of the deprecated messaget() constructor.