Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpp_parsert: construct with message handler #8142

Closed
wants to merge 5 commits into from
Closed

cpp_parsert: construct with message handler #8142

wants to merge 5 commits into from

Conversation

tautschnig
Copy link
Collaborator

This both avoids an object of static lifetime as well as it fixes the (transitive) use of the deprecated messaget() constructor.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig
C++ front-end: configure C++11+ syntax without ansi_c_parser object
8950a1a 
There is no need to access the parser object when the same information
is available directly from `config`.
@tautschnig
Make ansi_c_internal_additions independent of the parser object
a823425 
Thread through a Boolean flag rather than relying on the parser object
far away from the actual parser.
@tautschnig
Permit constructing parsert with a message handler
b4ef8b7 
This is to provide a path to remove the long-deprecated messaget()
constructor. Uses of this new constructor will be added in separate
commits.
@tautschnig
ansi_c_parsert: construct with message handler
bc5efc9 
This both avoids an object of static lifetime as well as it fixes the
(transitive) use of the deprecated messaget() constructor.
@tautschnig
cpp_parsert: construct with message handler
045c6e2 
This both avoids an object of static lifetime as well as it fixes the
(transitive) use of the deprecated messaget() constructor.
@tautschnig tautschnig self-assigned this Dec 20, 2023
@tautschnig
Copy link
Collaborator Author

Closing as the C++ front-end is too tightly coupled to the C front-end and the change needs to be merged with the ones in #8141 instead.

@tautschnig tautschnig closed this Jan 9, 2024
@tautschnig tautschnig deleted the cleanup/cpp_parsert branch January 9, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroening kroening Awaiting requested review from kroening kroening will be requested when the pull request is marked ready for review kroening is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel will be requested when the pull request is marked ready for review peterschrammel is a code owner

@feliperodri feliperodri Awaiting requested review from feliperodri feliperodri will be requested when the pull request is marked ready for review feliperodri is a code owner

@remi-delmas-3000 remi-delmas-3000 Awaiting requested review from remi-delmas-3000 remi-delmas-3000 will be requested when the pull request is marked ready for review remi-delmas-3000 is a code owner

Assignees

@tautschnig tautschnig

Labels
cleanup dependent - do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tautschnig