Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated messaget() constructor #8143

Merged

Conversation

tautschnig
Copy link
Collaborator

It is now no longer possible to construct a messaget object that is not fully configured, i.e., lacks a message handler.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Sorry, something went wrong.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.40%. Comparing base (8bab263) to head (8110e31).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8143      +/-   ##
===========================================
+ Coverage    78.23%   78.40%   +0.17%     
===========================================
  Files         1722     1722              
  Lines       188692   188260     -432     
  Branches     18452    18473      +21     
===========================================
- Hits        147615   147612       -3     
+ Misses       41077    40648     -429     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig force-pushed the cleanup/parsert-message-handler branch from 8faffdb to f499cc2 Compare June 12, 2024 14:29
@tautschnig tautschnig marked this pull request as ready for review June 12, 2024 14:29
This is never needed or used and would require default-constructing a
messaget, which is no longer possible.
It is now no longer possible to construct a messaget object that is not
fully configured, i.e., lacks a message handler.
@tautschnig tautschnig force-pushed the cleanup/parsert-message-handler branch from f499cc2 to 8110e31 Compare June 12, 2024 14:53
@tautschnig tautschnig merged commit 17cff12 into diffblue:develop Jun 12, 2024
39 of 40 checks passed
@tautschnig tautschnig deleted the cleanup/parsert-message-handler branch June 12, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants