Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document publishing GitHub Action #8152

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Jan 8, 2024

mermaid-filter depends on a deprecated version of puppeteer, which
results in puppeteer no longer finding a suitable version of Chromium.
See puppeteer/puppeteer#9533 for others facing
this issue. Forcing npm to use the most recent release of puppeteer
(version 21) resolves this problem.

We should revert the workflow to one that doesn't text-insert a
dependency and just directly npm installs mermaid-filter once
mermaid-js/mermaid-cli#627 has been resolved,
a new release of mermaid-cli been produced, and mermaid-filter having
picked up that new release.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Jan 8, 2024
@tautschnig tautschnig force-pushed the bugfixes/doc-job branch 6 times, most recently from e8682d0 to f5f15ea Compare January 8, 2024 10:10
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (78a90e0) 79.09% compared to head (71d3b4e) 79.09%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8152   +/-   ##
========================================
  Coverage    79.09%   79.09%           
========================================
  Files         1695     1695           
  Lines       196578   196578           
========================================
  Hits        155488   155488           
  Misses       41090    41090           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig force-pushed the bugfixes/doc-job branch 12 times, most recently from 0d776a4 to dd86080 Compare January 8, 2024 13:09
mermaid-filter depends on a deprecated version of puppeteer, which
results in puppeteer no longer finding a suitable version of Chromium.
See puppeteer/puppeteer#9533 for others facing
this issue. Forcing npm to use the most recent release of puppeteer
(version 21) resolves this problem.

We should revert the workflow to one that doesn't text-insert a
dependency and just directly npm installs mermaid-filter once
mermaid-js/mermaid-cli#627 has been resolved,
a new release of mermaid-cli been produced, and mermaid-filter having
picked up that new release.
@tautschnig tautschnig marked this pull request as ready for review January 8, 2024 13:17
@tautschnig tautschnig requested review from peterschrammel and a team as code owners January 8, 2024 13:17
@tautschnig tautschnig removed their assignment Jan 8, 2024
@tautschnig tautschnig merged commit 09dca35 into diffblue:develop Jan 9, 2024
39 checks passed
@tautschnig tautschnig deleted the bugfixes/doc-job branch January 9, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants