Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSIL front-end: no need for parser reentrancy #8153

Merged
merged 1 commit into from
Jan 11, 2024
Merged

JSIL front-end: no need for parser reentrancy #8153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/jsil/jsil_parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,5 @@ Author: Michael Tautschnig, [email protected]
/// Jsil Language

#include "jsil_parser.h"

int jsil_parsert::instance_count = 0;
17 changes: 15 additions & 2 deletions src/jsil/jsil_parser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,27 @@ class jsil_parsert:public parsert
explicit jsil_parsert(message_handlert &message_handler)
: parsert(message_handler)
{
// Simplistic check that we don't attempt to do reentrant parsing as the
// Bison-generated parser has global state.
PRECONDITION(++instance_count == 1);
}

jsil_parsert(const jsil_parsert &) = delete;

~jsil_parsert() override
{
--instance_count;
}

jsil_parse_treet parse_tree;

virtual bool parse() override
bool parse() override
{
jsil_scanner_init(*this);
return yyjsilparse(*this) != 0;
}

virtual void clear() override
void clear() override
{
parsert::clear();
parse_tree.clear();
Expand All @@ -47,6 +57,9 @@ class jsil_parsert:public parsert

// internal state of the scanner
std::string string_literal;

protected:
static int instance_count;
};

#endif // CPROVER_JSIL_JSIL_PARSER_H