Skip to content

C library: provide implementations of fopen64, freopen64 #8267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

tautschnig
Copy link
Collaborator

Some implementations map fopen and freopen, respectively, to the above when large-file support is enabled. To us, large-file support makes no difference, so just use a single implementation for both cases.

Will eventually fix Debian bug report 1069438.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Some implementations map fopen and freopen, respectively, to the above
when large-file support is enabled. To us, large-file support makes no
difference, so just use a single implementation for both cases.

Will eventually fix Debian bug report 1069438.
@kroening
Copy link
Member

I would have made fopen64 call fopen, but ok.

@tautschnig
Copy link
Collaborator Author

I would have made fopen64 call fopen, but ok.

I have intentionally not done this: fopen might be renamed to fopen64 via asm renaming or a macro. We would then end up with recursion in fopen64.

@tautschnig tautschnig merged commit 2a46ade into diffblue:develop Apr 29, 2024
37 of 38 checks passed
@tautschnig tautschnig deleted the features/stdio64 branch April 29, 2024 14:16
@kroening
Copy link
Member

I would have made fopen64 call fopen, but ok.

I have intentionally not done this: fopen might be renamed to fopen64 via asm renaming or a macro. We would then end up with recursion in fopen64.

Ok, that probably means that we will rename everything to some unique name eventually, say cprover_fopen etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants