Skip to content

Conversation

@tautschnig
Copy link
Collaborator

This will make behaviour consistent (and sound-by-default) across CBMC and goto-instrument.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig added the Version 6 Pull requests and issues requiring a major version bump label May 3, 2024
Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Consistent" and "sound-by-default" are things I love to see in a PR.

@martin-cs martin-cs removed their assignment May 5, 2024
@tautschnig tautschnig force-pushed the goto-instrument-unwinding-assertions branch from e13ae27 to 846a3e7 Compare May 6, 2024 11:30
@tautschnig tautschnig requested review from TGWDB and jimgrundy as code owners May 6, 2024 11:30
@tautschnig tautschnig force-pushed the goto-instrument-unwinding-assertions branch from 846a3e7 to 65b67cb Compare May 6, 2024 11:43
This will make behaviour consistent (and sound-by-default) across CBMC
and goto-instrument.
@tautschnig tautschnig force-pushed the goto-instrument-unwinding-assertions branch from 65b67cb to 900acce Compare May 6, 2024 12:16
@codecov
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.78%. Comparing base (ae7d311) to head (900acce).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8274      +/-   ##
===========================================
- Coverage    77.81%   77.78%   -0.04%     
===========================================
  Files         1721     1721              
  Lines       189460   189536      +76     
  Branches     18401    18401              
===========================================
+ Hits        147432   147434       +2     
- Misses       42028    42102      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig merged commit 89e4ded into diffblue:develop May 6, 2024
@tautschnig tautschnig deleted the goto-instrument-unwinding-assertions branch May 6, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Version 6 Pull requests and issues requiring a major version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants