-
Notifications
You must be signed in to change notification settings - Fork 273
CI: add macos-14 (macOS on M1) job #8382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8382 +/- ##
===========================================
+ Coverage 78.38% 78.88% +0.49%
===========================================
Files 1727 1727
Lines 188685 198333 +9648
Branches 18475 18475
===========================================
+ Hits 147900 156453 +8553
- Misses 40785 41880 +1095 ☔ View full report in Codecov by Sentry. |
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Jul 15, 2024
Since version 1.0.1, CVC5 also releases a binary for macOS ARM, which will enable CBMC CI runs on that platform (see diffblue#8382). More recent releases of CVC5, however, have also moved to releasing zip archives rather than single binaries. This necessitates an overhaul of the rules to download and install CVC5 beyond just changing the version number.
3 tasks
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Jul 15, 2024
Since version 1.0.1, CVC5 also releases a binary for macOS ARM, which will enable CBMC CI runs on that platform (see diffblue#8382). More recent releases of CVC5, however, have also moved to releasing zip archives rather than single binaries. This necessitates an overhaul of the rules to download and install CVC5 beyond just changing the version number.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Jul 15, 2024
Since version 1.0.1, CVC5 also releases a binary for macOS ARM, which will enable CBMC CI runs on that platform (see diffblue#8382). More recent releases of CVC5, however, have also moved to releasing zip archives rather than single binaries. This necessitates an overhaul of the rules to download and install CVC5 beyond just changing the version number.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Jul 15, 2024
Since version 1.0.1, CVC5 also releases a binary for macOS ARM, which will enable CBMC CI runs on that platform (see diffblue#8382). More recent releases of CVC5, however, have also moved to releasing zip archives rather than single binaries. This necessitates an overhaul of the rules to download and install CVC5 beyond just changing the version number.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Jul 15, 2024
Since version 1.0.1, CVC5 also releases a binary for macOS ARM, which will enable CBMC CI runs on that platform (see diffblue#8382). More recent releases of CVC5, however, have also moved to releasing zip archives rather than single binaries. This necessitates an overhaul of the rules to download and install CVC5 beyond just changing the version number.
This will exercise builds on ARM/Apple Silicon. Fixes: diffblue#8000
Once this one is merged I'd like to suggest that we drop the macos-12 job (I'll create a PR in due course). |
peterschrammel
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will exercise builds on ARM/Apple Silicon.
Fixes: #8000