-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump clang-format to clang-15 #8561
base: develop
Are you sure you want to change the base?
Conversation
aacfebe
to
cbf6562
Compare
clang 11 was released in 2007, and the last variant of Ubuntu with the clang-format-11 package is 22.04. This bumps the clang-format used for the formatting check to clang 15, available with Ubuntu 22.04 and 24.04.
cbf6562
to
9030c33
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8561 +/- ##
===========================================
+ Coverage 78.79% 78.95% +0.15%
===========================================
Files 1730 1730
Lines 199160 198759 -401
Branches 18320 18314 -6
===========================================
Hits 156938 156938
+ Misses 42222 41821 -401 ☔ View full report in Codecov by Sentry. |
apt-get install clang-format-11 # Run this on Ubuntu, Debian etc. | ||
brew install clang-format@11 # Run this on a Mac with Homebrew installed | ||
apt-get install clang-format-15 # Run this on Ubuntu, Debian etc. | ||
brew install clang-format # Run this on a Mac with Homebrew installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert on brew
, but this seems like it will break in future when the default is upgraded (where as all the other places and previous code are explicit about the version).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems Brew only has versioned variants for clang-format 8 and clang-format 11, while the latest one will install clang-format 19.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just say "clang-format 11 or later" -- our clang-format configuration file does not use options that were introduced in any version greater than 11, so this should be just fine.
apt-get install clang-format-11 # Run this on Ubuntu, Debian etc. | ||
brew install clang-format@11 # Run this on a Mac with Homebrew installed | ||
apt-get install clang-format-15 # Run this on Ubuntu, Debian etc. | ||
brew install clang-format # Run this on a Mac with Homebrew installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems Brew only has versioned variants for clang-format 8 and clang-format 11, while the latest one will install clang-format 19.
clang-format-15, available in the standard Ubuntu 24.04 and Homebrew | ||
repositories. To install on a Unix-like system, try installing using the | ||
system package manager: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-format-15, available in the standard Ubuntu 24.04 and Homebrew | |
repositories. To install on a Unix-like system, try installing using the | |
system package manager: | |
clang-format-11 or later, available in the standard Ubuntu and Homebrew | |
repositories. To install on a Unix-like system, try installing using the | |
system package manager: |
``` | ||
apt-get install clang-format-11 # Run this on Ubuntu, Debian etc. | ||
brew install clang-format@11 # Run this on a Mac with Homebrew installed | ||
apt-get install clang-format-15 # Run this on Ubuntu, Debian etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apt-get install clang-format-15 # Run this on Ubuntu, Debian etc. | |
apt-get install clang-format # Run this on Ubuntu, Debian etc. |
clang 11 was released in 2007, and the last variant of Ubuntu with the clang-format-11 package is 22.04.
This bumps the clang-format used for the formatting check to clang 15, available with 24.04.