bump clang-format to clang-15

[kroening]

clang 11 was released in 2007, and the last variant of Ubuntu with the clang-format-11 package is 22.04.

This bumps the clang-format used for the formatting check to clang 15, available with 24.04.

• Each commit message has a non-empty body, explaining why the change was made.
• n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.60%. Comparing base (6957a04) to head (08d558d).
Report is 4 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #8561   +/-   ##
========================================
  Coverage    79.60%   79.60%           
========================================
  Files         1733     1733           
  Lines       197358   197358           
  Branches     18165    18165           
========================================
  Hits        157111   157111           
  Misses       40247    40247           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TGWDB]

I'm not an expert on brew, but this seems like it will break in future when the default is upgraded (where as all the other places and previous code are explicit about the version).

[tautschnig]

It seems Brew only has versioned variants for clang-format 8 and clang-format 11, while the latest one will install clang-format 19.

[tautschnig]

Let's just say "clang-format 11 or later" -- our clang-format configuration file does not use options that were introduced in any version greater than 11, so this should be just fine.

[tautschnig]

It seems Brew only has versioned variants for clang-format 8 and clang-format 11, while the latest one will install clang-format 19.

[tautschnig]

Suggested change

	clang-format-15, available in the standard Ubuntu 24.04 and Homebrew
	repositories. To install on a Unix-like system, try installing using the
	system package manager:
	clang-format-11 or later, available in the standard Ubuntu and Homebrew
	repositories. To install on a Unix-like system, try installing using the
	system package manager:

[tautschnig]

Suggested change

	apt-get install clang-format-15 # Run this on Ubuntu, Debian etc.
	apt-get install clang-format # Run this on Ubuntu, Debian etc.

[kroening]

Let's just say "clang-format 11 or later" -- our clang-format configuration file does not use options that were introduced in any version greater than 11, so this should be just fine.

The reason for this PR is that the BreakBeforeBraces: Allman option does not work for the { before the body of a Lambda function. With clang-format 11, no break is added, requiring manual edits whenever using a later version. To see this, apply a later version of clang-format to the round_to_integral branch.

May I hence suggest the wording "clang-format 15 or later".

[tautschnig]

Let's just say "clang-format 11 or later" -- our clang-format configuration file does not use options that were introduced in any version greater than 11, so this should be just fine.

The reason for this PR is that the BreakBeforeBraces: Allman option does not work for the { before the body of a Lambda function. With clang-format 11, no break is added, requiring manual edits whenever using a later version. To see this, apply a later version of clang-format to the round_to_integral branch.

May I hence suggest the wording "clang-format 15 or later".

Ah, I wasn't aware of that difference in behaviour. Sure, let's use "clang-format 15 or later" in that case. (apt-get install clang-format installs version 18 on Ubuntu 24.04, so that would actually be fine for simplified user instructions.)