Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove set but not used variables #8595

Merged

Conversation

mgudemann
Copy link
Contributor

clang 19.1.17 warns about set but not used variables and stops compilation because of -Werror

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.37%. Comparing base (41e9f3d) to head (0e7b4ac).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
src/solvers/flattening/boolbv_overflow.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8595      +/-   ##
===========================================
- Coverage    80.38%   80.37%   -0.01%     
===========================================
  Files         1686     1686              
  Lines       206770   206767       -3     
  Branches        85       85              
===========================================
- Hits        166207   166198       -9     
- Misses       40563    40569       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig
Copy link
Collaborator

@mgudemann Please rebase as the set of required CI checks has been adjusted.

clang 19.1.17 warns about `set but not used` variables and stops compilation
because of `-Werror`
@mgudemann mgudemann force-pushed the fix/remove_set_but_unused_variables branch from 900dee6 to 0e7b4ac Compare April 4, 2025 08:29
@tautschnig tautschnig merged commit df9adc9 into diffblue:develop Apr 4, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants