Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion of Qmin and Qmax and update test data #62

Closed
wants to merge 4 commits into from
Closed

Inclusion of Qmin and Qmax and update test data #62

wants to merge 4 commits into from

Conversation

cadenmyers13
Copy link
Contributor

@cadenmyers13 cadenmyers13 commented Nov 8, 2024

closes #61. I did this in reference to this comment #47 (comment). I created the new data through the test function which might not be ideal but this was the quickest way I could do it. I had to create new fourier transformed data as well for the other test because it relied on the old data. Pytest passes on this now, and when I ran pytest on the old source code (>=/<= instead of >/<) it passed. Now that I'm thinking about it, I might be able to make new test data from the included test data files by just trimming the data...

TL;DR I changed the test data and pytest failed when expected and passed when expected. Also, the source code has been updated for the desired Q masking.

@bobleesj mention you just so you can see

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (46c65be) to head (beea0ee).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files           4        4           
  Lines         169      169           
=======================================
  Hits          158      158           
  Misses         11       11           

@bobleesj
Copy link
Contributor

bobleesj commented Nov 8, 2024

@bobleesj mention you just so you can see

Thanks for tagging. Yes, I am "watching" this repository.

@sbillinge
Copy link
Contributor

Thanks Caden. I need to take a quick look at this. On my phone right now.

@cadenmyers13
Copy link
Contributor Author

@sbillinge no problem. Let me know if you want to see screenshots of anything for confirmation.

@sbillinge
Copy link
Contributor

Closing. replaced by #63

@sbillinge sbillinge closed this Nov 9, 2024
@cadenmyers13 cadenmyers13 deleted the testingv2 branch November 28, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qmin Qmax to be within mask range
3 participants