Inclusion of Qmin and Qmax and update test data #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #61. I did this in reference to this comment #47 (comment). I created the new data through the test function which might not be ideal but this was the quickest way I could do it. I had to create new fourier transformed data as well for the other test because it relied on the old data. Pytest passes on this now, and when I ran pytest on the old source code (
>=
/<=
instead of>
/<
) it passed. Now that I'm thinking about it, I might be able to make new test data from the included test data files by just trimming the data...TL;DR I changed the test data and pytest failed when expected and passed when expected. Also, the source code has been updated for the desired Q masking.
@bobleesj mention you just so you can see