Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add h5py import to documentation build #67

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Conversation

Sparks29032
Copy link
Contributor

Should populate the documentation when merged.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (ec3f5b3) to head (e4b8287).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files           4        4           
  Lines         177      177           
=======================================
  Hits          166      166           
  Misses         11       11           

@bobleesj
Copy link
Contributor

@Sparks29032 If this PR was to fix the API building problem issue in fourigui, what was the issue? I am afraid this may happen in other packages.

news/h5py.rst Outdated
@@ -0,0 +1,23 @@
**Added:**

* Documentation-level fix.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a fixed rather than an add?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@sbillinge sbillinge merged commit 402e7d5 into diffpy:main Nov 13, 2024
5 checks passed
@Sparks29032 Sparks29032 deleted the h5py branch November 13, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants