Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-cookiecut to follow new group standard #156

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

yucongalicechen
Copy link
Collaborator

closes #149
@sbillinge ready for review

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (8ef887c) to head (d3c9eee).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files           5        5           
  Lines         254      254           
=======================================
  Hits          252      252           
  Misses          2        2           
Files with missing lines Coverage Δ
tests/conftest.py 100.00% <100.00%> (ø)
tests/test_functions.py 100.00% <100.00%> (ø)
tests/test_tools.py 98.50% <100.00%> (ø)
tests/test_version.py 100.00% <ø> (ø)

@sbillinge
Copy link
Contributor

Thanks @yucongalicechen . There are some flake8 errors to fix. We have @bobleesj to thank for this as we changed the line length from 115 to 79, but on the whole we decided this was a good change. It makes it easier to compare code line by line and work on smaller devices, which is why we decided to go this way.

@yucongalicechen
Copy link
Collaborator Author

yucongalicechen commented Jan 28, 2025

Thanks @yucongalicechen . There are some flake8 errors to fix. We have @bobleesj to thank for this as we changed the line length from 115 to 79, but on the whole we decided this was a good change. It makes it easier to compare code line by line and work on smaller devices, which is why we decided to go this way.

Ah, missed that, I'll edit those lines

@yucongalicechen
Copy link
Collaborator Author

@sbillinge ready for another review!

@sbillinge sbillinge merged commit 983a7b0 into diffpy:main Jan 29, 2025
5 checks passed
@yucongalicechen yucongalicechen deleted the recut2 branch January 29, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants