closes #24: check if args.input_file is specified #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbillinge
reviewed
Apr 29, 2024
| xarray, yarray = loadData(filepath.name, unpack=True) | ||
| try: | ||
| xarray, yarray = loadData(filepath, unpack=True) | ||
| except Exception as e: |
There was a problem hiding this comment.
please specify a specific exception or exceptions, not a general one.
|
This is supposed to link to the open PR that replaced it, but it is not a
big deal, don't bother updating it. For future reference, I would write
something like "closing as replaced by #50" something like that.
…On Tue, May 7, 2024, 9:53 AM Yucong (Alice) Chen ***@***.***> wrote:
Closed #35 <#35>.
—
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAOWUIEHREKUHZR27G3RK3ZBDMEJAVCNFSM6AAAAABG6N43ISVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSG4ZTAMBSGQZDSMI>
.
You are receiving this because you commented.Message ID: <diffpy/diffpy.
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit
Specify input directory with default as cwd, glob all files in directory and write outputs
Skip non-readable files using loadData (try except and provide an error message)
(need suggestions) still need to implement the following: compute cve only one time. We probably need to split compute_cve function to achieve this, having one function compute cves using tth we defined, and a second function to interpolat across different tths for different input files.