implement functionality to allow input selection or skipping of files #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we are implementing these UCs in this release. That are
something someone might want to do but we will wait to see how users use
the code before implementing them
…On Thu, May 23, 2024, 6:11 PM Yucong (Alice) Chen ***@***.***> wrote:
I went through the UCs and test cases in #48
<#48> and there left
these cases (I addressed UC7 and -file7,chi in this PR and will probably
address UC5 in another PR):
- UC5: multiple files, different samples (file1.chi 2.5 file2.chi 3.5)
- UC7: automatically selects the right files to apply the correction
to (don't read _corrected and _cve).
- -file7.chi (specify files don’t want to read). Here - will be taken
as one of the arguments so I changed it to ~.
------------------------------
You can view, comment on, or merge this pull request online at:
#72
Commit Summary
- c8c0071
<c8c0071>
excluded reading _corrected and _cve files
- f495565
<f495565>
added functionality to automatically select files and skipping files
File Changes
(4 files <https://github.com/diffpy/diffpy.labpdfproc/pull/72/files>)
- *M* src/diffpy/labpdfproc/labpdfprocapp.py
<https://github.com/diffpy/diffpy.labpdfproc/pull/72/files#diff-5dac184d5afea97c0b77258be37462d3d08aabaa60ba14882d8bf3a502d51927>
(3)
- *M* src/diffpy/labpdfproc/tests/conftest.py
<https://github.com/diffpy/diffpy.labpdfproc/pull/72/files#diff-55312013d19e21fd2c1f81b947a970daaca6cfb637bce27b9757416586e789f0>
(8)
- *M* src/diffpy/labpdfproc/tests/test_tools.py
<https://github.com/diffpy/diffpy.labpdfproc/pull/72/files#diff-972495a76a6a469ac3d0228bccf570e688e77c3a5962d02ed2da0b2ffbd9fdc9>
(4)
- *M* src/diffpy/labpdfproc/tools.py
<https://github.com/diffpy/diffpy.labpdfproc/pull/72/files#diff-c982ef80888d672f298d53201af1be02db7e8713509ca9e05dbeb1bb8f71d211>
(18)
Patch Links:
- https://github.com/diffpy/diffpy.labpdfproc/pull/72.patch
- https://github.com/diffpy/diffpy.labpdfproc/pull/72.diff
—
Reply to this email directly, view it on GitHub
<#72>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAOWUMSVHMQ4YKIMBTMPL3ZDZSSJAVCNFSM6AAAAABIGPCWN6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYTGOJUGAZDKOA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #52
I went through the UCs and test cases in #48 and there left these cases (I addressed UC7 and -file7,chi in this PR and will probably address UC5 in another PR):
For 2, I didn't add any additional test cases and put some corrected files in our tmp path.
For 3, since - would be taken as one of the arguments, I changed it to ~.