Skip to content

skpkg: add configuration files for pre-commit, readthedocs, codecov #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 11, 2025

Conversation

zmx27
Copy link
Contributor

@zmx27 zmx27 commented Jun 11, 2025

#201 needs to be closed first

Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.23%. Comparing base (c6cad31) to head (fc5bac1).
Report is 7 commits behind head on migration.

Additional details and impacted files
@@            Coverage Diff             @@
##           migration     #202   +/-   ##
==========================================
  Coverage      97.23%   97.23%           
==========================================
  Files             20       20           
  Lines            903      903           
==========================================
  Hits             878      878           
  Misses            25       25           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, this looks ok. I am not sure if we want the blocks with setup.cfg and the socioeconomic etc. that you added back in the last commit. Why did you add htat back? Was it not passing pre-commit without those? They are small things though, it doesn't really matter that much if they are there but not needed (just a bit of technical debt to carry forward to the future). But let me know why you added them back (as well as addressing the one inline issue).

This is marked as draft. Is there a reason for this? It is not finished on your side?

@zmx27 zmx27 marked this pull request as ready for review June 11, 2025 16:17
@zmx27
Copy link
Contributor Author

zmx27 commented Jun 11, 2025

Sorry, I forgot to mark it as review yesterday. Regarding setup.cfg, I thought it seemed quite important for normal functionality, but I deleted it if it's not required. As for the socioeconomic block, it seems to be necessary to pass pre-commit. @sbillinge ready for review after addressing your inline comment

@sbillinge
Copy link
Contributor

OK, I can merge it like this.

@sbillinge sbillinge merged commit 40c9f88 into diffpy:migration Jun 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants