Put the MorphRGrid at the end of the morphing chain
#232
Conversation
|
Note that only the The files changed should go away once #231 is merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
=======================================
Coverage 99.08% 99.08%
=======================================
Files 21 21
Lines 1087 1087
=======================================
Hits 1077 1077
Misses 10 10 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
I will merge this so you can move ahead, but please see comment and make an issue. Also, in common with things like np.all_cloae etc, could we drop the "are" from the name and make it more like files_all_close or something like that. We could also borrow the signature and pass through tolerances. Again, this can be done later, after beam time... Just make an issue now so we don't forget
tests/test_morphio.py
Outdated
| @@ -50,6 +50,20 @@ def isfloat(s): | |||
| return False | |||
|
|
|||
|
|
|||
| def are_files_same(file1, file2): | |||
| """Assert that two files have (approximately) the same numerical | |||
There was a problem hiding this comment.
This looks as if it is a copy paste of the one in the other PR. Can we put it into conftest. Py and make it available to all tests as a fixture?
There was a problem hiding this comment.
It is from the other PR. After merging with main, this change is no longer present.
There was a problem hiding this comment.
This is only needed in the io tests as that is the only test creating files. As such, no need to put into contest.
|
Created #233 just in case we want to revisit names. |
See news (
config_order.rst) comment for why this is done. Preparation formorphfuncxandmorphfuncxy.