Skip to content

Bug fix for --smear-pdf #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025
Merged

Bug fix for --smear-pdf #234

merged 2 commits into from
Jul 10, 2025

Conversation

Sparks29032
Copy link
Collaborator

See change in-line. When converting from RDF to PDF, a division by r is done. Since we know the point at which r=0 corresponds to g(r=0)=0, we set g(r=0)=0 to avoid a divide-by-zero. The setting for the morph g(r) incorrectly uses the target r-grid to do this setting to zero.

Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.08%. Comparing base (f8ee98a) to head (7758973).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files          21       21           
  Lines        1087     1087           
=======================================
  Hits         1077     1077           
  Misses         10       10           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sparks29032
Copy link
Collaborator Author

Request for a test that would have caught this error added to #233.

@sbillinge sbillinge merged commit 742643c into diffpy:main Jul 10, 2025
5 checks passed
@Sparks29032 Sparks29032 deleted the smear-pdf-bug branch July 10, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants