Skip to content

fix: win_py13 SystemError from pytest #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 12, 2025
Merged

Conversation

Tieqiong
Copy link
Contributor

@Tieqiong Tieqiong commented Jan 12, 2025

closes #102 address #96
@sbillinge please check, thanks

This was a tough one... I hate how Windows error messages provide 0 information

@Tieqiong Tieqiong changed the title Win memory Win memory (review #121 first please) Jan 12, 2025
@Tieqiong Tieqiong changed the title Win memory (review #121 first please) Win memory Jan 12, 2025
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.96%. Comparing base (fdc2e16) to head (d6129aa).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files           6        6           
  Lines        1261     1262    +1     
=======================================
+ Hits         1248     1249    +1     
  Misses         13       13           
Files with missing lines Coverage Δ
tests/conftest.py 73.52% <100.00%> (+0.80%) ⬆️

@Tieqiong Tieqiong changed the title Win memory fix: win_py13 SystemError from pytest Jan 12, 2025
Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!!!!!

@sbillinge sbillinge merged commit 913583a into diffpy:main Jan 12, 2025
5 checks passed
@bobleesj
Copy link
Contributor

🦾🦾🦾 incredible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Python 3.13 matrix-coverage test fails
3 participants