Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: change background color to match system #243

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

cadenmyers13
Copy link
Contributor

closes #242

See screenshots for how this change affects interface.

dark mode

Screenshot 2025-01-13 at 12 37 32 PM

light mode

Screenshot 2025-01-13 at 12 36 48 PM

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (5e5cc7f) to head (e7d0b9e).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   95.11%   95.10%   -0.02%     
==========================================
  Files          23       23              
  Lines        1126     1123       -3     
==========================================
- Hits         1071     1068       -3     
  Misses         55       55              

see 22 files with indirect coverage changes

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls see inline

src/diffpy/pdfgui/gui/phaseconfigurepanel.py Outdated Show resolved Hide resolved
@cadenmyers13
Copy link
Contributor Author

cadenmyers13 commented Jan 15, 2025

@sbillinge Okay, I think this is better. its formatted in the same way as the dataset panels (see code snippet below). Gray text is non-editable by the user which is desired behavior i believe.

Test failed... will investigate

Screenshot 2025-01-15 at 10 38 29 AM

Screenshot 2025-01-15 at 10 35 52 AM
Screenshot 2025-01-15 at 10 36 00 AM
Screenshot 2025-01-15 at 10 36 16 AM
Screenshot 2025-01-15 at 10 36 24 AM

@sbillinge
Copy link
Contributor

@cadenmyers13 ok, that looks better. Please can you put side-by-side what the current and new-PR versions of those panels are in light mode so we can be sure that also this aspect is not unduly affected? Thx.

@cadenmyers13

This comment was marked as duplicate.

@sbillinge
Copy link
Contributor

@cadenmyers13 please could you do me a favor and check it over very carefully and circle all the places there are differences in light and dark mode. Thx

@cadenmyers13
Copy link
Contributor Author

@sbillinge Here is the comparison. The only difference is in the dark mode. Light mode has not been affected which is the desired behavior.

Current version - dark

Screenshot 2025-01-16 at 10 05 49 AM

New version - dark

Screenshot 2025-01-16 at 10 20 44 AM

Current version - light

Screenshot 2025-01-16 at 10 09 32 AM

New version - light

Screenshot 2025-01-16 at 10 12 17 AM

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cadenmyers13 thanks, this is nearly there. Please remove the commented line.

src/diffpy/pdfgui/gui/phaseconfigurepanel.py Outdated Show resolved Hide resolved
@cadenmyers13
Copy link
Contributor Author

@sbillinge done!

@sbillinge
Copy link
Contributor

Great work! Thanks @cadenmyers13 !!!

@sbillinge sbillinge merged commit c446969 into diffpy:main Jan 17, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Background coloring in textbox when using macOS in dark mode
2 participants