-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: change background color to match system #243
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
==========================================
- Coverage 95.11% 95.10% -0.02%
==========================================
Files 23 23
Lines 1126 1123 -3
==========================================
- Hits 1071 1068 -3
Misses 55 55 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls see inline
@sbillinge Okay, I think this is better. its formatted in the same way as the dataset panels (see code snippet below). Gray text is non-editable by the user which is desired behavior i believe. Test failed... will investigate |
@cadenmyers13 ok, that looks better. Please can you put side-by-side what the current and new-PR versions of those panels are in light mode so we can be sure that also this aspect is not unduly affected? Thx. |
This comment was marked as duplicate.
This comment was marked as duplicate.
@cadenmyers13 please could you do me a favor and check it over very carefully and circle all the places there are differences in light and dark mode. Thx |
@sbillinge Here is the comparison. The only difference is in the dark mode. Light mode has not been affected which is the desired behavior. Current version - darkNew version - darkCurrent version - lightNew version - light |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cadenmyers13 thanks, this is nearly there. Please remove the commented line.
@sbillinge done! |
Great work! Thanks @cadenmyers13 !!! |
closes #242
See screenshots for how this change affects interface.
dark mode
light mode