Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix online manual image and doc links #254

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

Tieqiong
Copy link
Contributor

@Tieqiong Tieqiong commented Jan 16, 2025

replaces #247 and #248
closes #186

@sbillinge please check, thanks.

This PR includes two changes (fix image not showing in release and update documentation links in manual). I put them together to avoid conflict. The update manual one doesn't need a news so I'm not adding an extra news.

I'm moving the html and image sources back to doc/manual (which I moved to doc/source before). This is better as it's much more organized and making sense. Everything related to the manual is in one place now. We can still reach them by the modification in conf.py.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.11%. Comparing base (1cb1890) to head (272c3f3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files          23       23           
  Lines        1126     1126           
=======================================
  Hits         1071     1071           
  Misses         55       55           

@sbillinge
Copy link
Contributor

replaces #247 and #248 closes #186

@sbillinge please check, thanks.

This PR includes two changes (fix image not showing in release and update documentation links in manual). I put them together to avoid conflict. The update manual one doesn't need a news so I'm not adding an extra news.

I'm moving the html and image sources back to doc/manual (which I moved to doc/source before). This is better as it's much more organized and making sense. Everything related to the manual is in one place now. We can still reach them by the modification in conf.py.

thanks for the detailed explanation @Tieqiong , this is really helpfule!

@sbillinge sbillinge merged commit ffc429c into diffpy:main Jan 16, 2025
5 checks passed
@Tieqiong Tieqiong deleted the html branch January 17, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace DANSE links
2 participants