Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ending support for WX3 #259

Merged
merged 3 commits into from
Jan 18, 2025
Merged

refactor: ending support for WX3 #259

merged 3 commits into from
Jan 18, 2025

Conversation

Tieqiong
Copy link
Contributor

closes #144

@sbillinge please check, thanks

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (c446969) to head (9a7c48f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files          23       23           
  Lines        1123     1123           
=======================================
  Hits         1068     1068           
  Misses         55       55           

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Is there a way to check that it didn't break anything?

news/wx3.rst Outdated Show resolved Hide resolved
@Tieqiong
Copy link
Contributor Author

@sbillinge I'm not sure if there's any other ways except the matrix CI test and some manual pre-release tests... At least I played with it for a while and didn't see anything unusual.

@sbillinge sbillinge merged commit b7c5c65 into diffpy:main Jan 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove wx3 support that is already deprecated
2 participants