Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix TypeError when using Nyquist interp #268

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

Tieqiong
Copy link
Contributor

@Tieqiong Tieqiong commented Feb 5, 2025

@sbillinge please check, thanks

Previously when using nyquest grid it will give error like

TypeError: '<' not supported between instances of 'list' and 'float'

which is because the sampler function in diffpy.utils only accept ndarray while pdfgui provide array_like (list) type

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (9a0cf41) to head (8b3c51f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files          23       23           
  Lines        1123     1123           
=======================================
  Hits         1068     1068           
  Misses         55       55           

@sbillinge sbillinge merged commit ce00937 into diffpy:main Feb 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants