Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory structuring #2

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Conversation

Sparks29032
Copy link
Contributor

@Sparks29032 Sparks29032 commented Jan 31, 2025

Closes #1

Copy link

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

Copy link

codecov bot commented Jan 31, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@sbillinge
Copy link
Contributor

@Sparks29032 (cc @tinatn29) Great, we are off! Please create a conda env for this locally, install pre-commit and then run pre-commit install to get all the linting running locally before you push.

Don't forget to put closes #2 in the top-most comment so the issue closes when the PR merges.

We are also now trying to get in the habit of using prefixes to PR names and commits to help keep track. This work is probably chore: directory structure.

But also in general, mention a few words about your intention for the reviewer.... Do you want me to merge this as it is, or is it an intermediate commit. Just a few words so we know what we are after doing....

@Sparks29032
Copy link
Contributor Author

Closes #1

Once pre-commit passes, let us merge (without news since this is not a major feature change).

@Sparks29032
Copy link
Contributor Author

@sbillinge Do we want a "tools" repository or another name for helper functions such as ones that convert from .cif to .cgr.

@sbillinge
Copy link
Contributor

Thanks for the @Sparks29032 ! I move the closes #1 to the top level comment box where it has to be to work. Let's work on tagging issue/PR names and commit messages in future commits.

@sbillinge sbillinge merged commit 807423a into diffpy:main Feb 6, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High-Level Framework
2 participants