-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PyPI/GitHub checklist via Issues (closed due to unnecessary commits) #106
Conversation
- [ ] Grammar and writing quality have been checked. | ||
- [ ] License information is verified. If you are unsure, please comment below. | ||
|
||
Please mention @sbillinge when you are ready for release. Include any additional comments necessary, such as version information and details about the pre-release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checks license, installation instructions, badges, docs, grammar, writing quality, PR/issues, cookiecutting status.
Ready for review @sbillinge |
Added news to pass the CI.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the checklist. I have a few edit suggestsions. But this PR seems to be a bit dirty....lots of old commits. Do you know why? Is there a way to remake the PR with just one commit on it?
@sbillinge Yes, a new PR is created instead: #107 I must have pushed some commits to |
Please suggest for any additional items in the checklist that could be added.
@sbillinge @alisnwu