Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyPI/GitHub checklist via Issues (closed due to unnecessary commits) #106

Closed
wants to merge 15 commits into from

Conversation

bobleesj
Copy link
Contributor

Please suggest for any additional items in the checklist that could be added.

@sbillinge @alisnwu

- [ ] Grammar and writing quality have been checked.
- [ ] License information is verified. If you are unsure, please comment below.

Please mention @sbillinge when you are ready for release. Include any additional comments necessary, such as version information and details about the pre-release.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checks license, installation instructions, badges, docs, grammar, writing quality, PR/issues, cookiecutting status.

@bobleesj bobleesj marked this pull request as ready for review October 19, 2024 00:18
@bobleesj
Copy link
Contributor Author

Ready for review @sbillinge

@bobleesj
Copy link
Contributor Author

Added news to pass the CI..

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the checklist. I have a few edit suggestsions. But this PR seems to be a bit dirty....lots of old commits. Do you know why? Is there a way to remake the PR with just one commit on it?

@bobleesj
Copy link
Contributor Author

bobleesj commented Oct 19, 2024

@sbillinge Yes, a new PR is created instead: #107

I must have pushed some commits to origin/main to run CI steps a while ago.

@bobleesj bobleesj closed this Oct 19, 2024
@bobleesj bobleesj deleted the issue branch October 19, 2024 16:42
@bobleesj bobleesj changed the title Add PyPI/GitHub checklist via Issues Add PyPI/GitHub checklist via Issues (closed due to necessary commits) Oct 19, 2024
@bobleesj bobleesj changed the title Add PyPI/GitHub checklist via Issues (closed due to necessary commits) Add PyPI/GitHub checklist via Issues (closed due to unnecessary commits) Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants