Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc #125

Closed
wants to merge 5 commits into from
Closed

Doc #125

wants to merge 5 commits into from

Conversation

Fil158
Copy link

@Fil158 Fil158 commented Oct 29, 2024

I have fixed some typos on the online documentation.

Copy link

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

@bobleesj
Copy link
Contributor

bobleesj commented Oct 29, 2024

@Fil158 Thanks Fillipo - if you recall, we should make issues first and then we make PR to address those issues.

Could you please close this PR and make anew PR for fixing typos only for now? Please detail your reasoning/problems by creating issues.

Copy link
Contributor

@bobleesj bobleesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see in-line comments @Fil158

@bobleesj
Copy link
Contributor

Furthermore - the workflow instruction asks you run pre-commit please run it before making a PR.

@bobleesj
Copy link
Contributor

@Fil158 Another comment is that - you want to make the title of the PR/issue descriptive but concise. Please cross-check other PRs merged.

@Fil158 Fil158 closed this Oct 29, 2024
@Fil158 Fil158 reopened this Oct 29, 2024
@Fil158
Copy link
Author

Fil158 commented Oct 29, 2024

Ok

@Fil158 Fil158 closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants