Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recut - codecov in PR, Codespell, release checklist #136

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Nov 8, 2024

Closes #134

Copy link

github-actions bot commented Nov 8, 2024

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.96%. Comparing base (3352045) to head (b4671ec).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #136       +/-   ##
===========================================
+ Coverage   71.07%   91.96%   +20.88%     
===========================================
  Files           9        7        -2     
  Lines         242      112      -130     
===========================================
- Hits          172      103       -69     
+ Misses         70        9       -61     

see 16 files with indirect coverage changes

@bobleesj
Copy link
Contributor Author

bobleesj commented Nov 8, 2024

@sbillinge ready for review - py3.13, codecov, pytest, warning resolved.

no additional news added since we've already implemented codecov and spelling check before.

@bobleesj bobleesj marked this pull request as ready for review November 8, 2024 04:06
@sbillinge sbillinge merged commit 630ce2c into diffpy:main Nov 8, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Codecov Report in PR (new cookiecutting standard)
2 participants