feat: Add random state feature. #150
Conversation
john-halloran
commented
Jun 6, 2025
john-halloran
commented
- feat: Added random_state feature for reproducibility.
| components=None, | ||
| random_state=None, | ||
| ): | ||
|
|
||
| self.MM = MM |
| MM, | ||
| Y0=None, | ||
| X0=None, | ||
| A=None, |
| @@ -4,8 +4,20 @@ | |||
|
|
|||
|
|
|||
| class SNMFOptimizer: | |||
| def __init__(self, MM, Y0=None, X0=None, A=None, rho=1e12, eta=610, max_iter=500, tol=5e-7, components=None): | |||
There was a problem hiding this comment.
we need a docstring here and in the init. Please see scikit-package FAQ about how to write these. Also, look at Yucong's code or diffpy.utils?
| @@ -15,23 +27,22 @@ def __init__(self, MM, Y0=None, X0=None, A=None, rho=1e12, eta=610, max_iter=500 | |||
| # Capture matrix dimensions | |||
| self.N, self.M = MM.shape | |||
| self.num_updates = 0 | |||
| self.rng = np.random.default_rng(random_state) | |||
There was a problem hiding this comment.
can we have a more descriptive variable name? Is this a range? What is the range?
| if self.A is None: | ||
| self.A = np.ones((self.K, self.M)) + np.random.randn(self.K, self.M) * 1e-3 # Small perturbation | ||
| self.A = np.ones((self.K, self.M)) + self.rng.normal(0, 1e-3, size=(self.K, self.M)) |
There was a problem hiding this comment.
K and M are probably good names if the matrix decomposition equation is in hte docstring, so they get defined there.
Thanks, will work on resolving these. To be clear, for things like the docstrings would you prefer I make new PRs, get those merged, then rebase this one, or just add to this existing PR? |
