function load_input_signal refactor #42
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajayi-21
commented
Aug 2, 2023
| @@ -3,6 +3,9 @@ | |||
| from pathlib import Path | |||
| from diffpy.utils.parsers.loaddata import loadData | |||
|
|
|||
| PDF_FILE_EXTENSIONS = {'.gr', '.cgr'} | |||
| DIFFRACTION_FILE_EXTENSIONS = {'.chi', 'iq', 'xye', '.xrd', '.xy'} | |||
There was a problem hiding this comment.
In a much earlier comment, you mentioned that finding the file type by the file extension may not be a good idea. Do you know of any libraries that can do this (such as in diffpy.utils).
There was a problem hiding this comment.
it looks to me as if you are trying to find the data_type from the extension. Is that right or is it teh file-type you are after? LoadData is pretty flexible, it should successfully read all the file extensions you put up there (I am not familiar with .xrd)
There was a problem hiding this comment.
in other words, I don;t think you need to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.