Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 3/3 of Cookiecutter pre-commit workflow (precommit) #55

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Aug 2, 2024

The last precommit section in Step 11-17.

Below, precommit screenshot:

Screenshot 2024-08-01 at 11 03 46 PM

This precommit branch is continued from flake8(has not been merged as of now). Is this still okay? @sbillinge - I am asking this because I have not submitted another PR before my previous branch has been merged.

@bobleesj
Copy link
Contributor Author

bobleesj commented Aug 2, 2024

Great, precommit check works.

@sbillinge
Copy link
Contributor

@bobleesj this is great! Thanks, I merged.

@sbillinge sbillinge merged commit 504568e into diffpy:cookie Aug 2, 2024
2 checks passed
@bobleesj bobleesj deleted the precommit branch August 2, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants