Update docs.yml, main.yml and doc building files #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobleesj
commented
Aug 12, 2024
| @@ -38,6 +38,19 @@ jobs: | |||
| - name: build documents | |||
| run: make -C doc html | |||
|
|
|||
| - name: Run tests and upload coverage | |||
There was a problem hiding this comment.
Based on Aug 12, 2024 changes to docs.yml
bobleesj
commented
Aug 12, 2024
| @@ -50,10 +50,6 @@ jobs: | |||
| shell: bash -l {0} | |||
| run: | | |||
| conda activate test | |||
| coverage run run_tests.py | |||
There was a problem hiding this comment.
Do we not need run_tests.py anymore then?
It felt awkward to have a separate file for running pytest, indeed.
sbillinge
reviewed
Aug 12, 2024
| repository: diffpy/diffpy.snmf | ||
| # for bookkeeping have diffpy.snmf at the same level as everything else in the | ||
| # directory tree | ||
| repository: REPO_NAME | ||
| path: . |
There was a problem hiding this comment.
This doesn't look right, are you sure?
There was a problem hiding this comment.
Yes, that was found during my PR review and fixed probably while you were reviewing.
There was a problem hiding this comment.
I believe it should be gone when "refreshed".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs.ymlandmain.ymlCI files based on Aug 11, 2024 udpateMakefileandmake.bat