Cookiecut (first time) #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review @sbillinge Half of the changes are due to doc files generated automatically. |
sbillinge
reviewed
Sep 30, 2024
README.rst
Outdated
|
|
||
| If you use diffpy.srfit in a scientific publication, we would like you to cite this package as | ||
|
|
||
| diffpy.srfit Package, https://github.com/diffpy/diffpy.srfit |
There was a problem hiding this comment.
please have them cite the diffpy-cmi complex modeling paper. Please have them cite this same paper for:
srfit
srreal
structure
utils
...am I forgetting any? not pdfmorph/snmf/fourigui which are separate packages.
README.rst
Outdated
| complex modeling initiative at the Brookhaven National Laboratory. The | ||
| diffpy.srfit sources are hosted at | ||
| https://github.com/diffpy/diffpy.srfit. | ||
| complex modeling initiative at the Brookhaven National Laboratory. |
There was a problem hiding this comment.
please change this to Columbia University.
bobleesj
commented
Oct 1, 2024
| @@ -156,7 +163,7 @@ Support and Contribute | |||
| If you see a bug or want to request a feature, please `report it as an issue <https://github.com/diffpy/diffpy.srfit/issues>`_ and/or `submit a fix as a PR <https://github.com/diffpy/diffpy.srfit/pulls>`_. You can also post it to the `Diffpy user group <https://groups.google.com/g/diffpy-users>`_. | |||
|
|
|||
| diffpy.srfit is an open-source software developed as a part of the DiffPy-CMI | |||
| complex modeling initiative at the Brookhaven National Laboratory. | |||
| complex modeling initiative at Columbia University. | |||
bobleesj
commented
Oct 1, 2024
| @@ -67,9 +67,16 @@ http://diffpy.github.io/diffpy.srfit. | |||
| Citation | |||
| -------- | |||
|
|
|||
| If you use diffpy.srfit in a scientific publication, we would like you to cite this package as | |||
| If you use this program for a scientific research that leads | |||
There was a problem hiding this comment.
Added citation
- made PRs to diffpy.srreal and diffpy.utils, adding citation
|
@sbillinge ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cookiecut for the first time
Docs running nicely.