Move tests folder to top dir level #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbillinge
reviewed
Sep 13, 2024
|
@sbillinge |
|
@bobleesj I am afraid that removing the init broke this. We could add it back, but in general, if there is another approach (some small edits to the tests needed to make them pass without that init) it would be preferred so we don't have some packages differently structured from others.... |
|
@sbillinge Please review the latest change. CI isn't running here but checked it using my remote branch. 
|
I am committed to this. |
sbillinge
reviewed
Sep 14, 2024
| @@ -45,7 +45,6 @@ dirty_template = "{tag}" | |||
| [tool.setuptools.packages.find] | |||
| where = ["src"] # list of folders that contain the packages (["."] by default) | |||
| include = ["*"] # package names should match these glob patterns (["*"] by default) | |||
| exclude = ["diffpy.structure.tests*"] # exclude packages matching these glob patterns (empty by default) | |||
There was a problem hiding this comment.
Please leave this in but with an empty list.
is used now. Please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
==== 138 passed in 11.16s =====
After:
===138 passed in 1.51s ======
Using
conftest, local pytest runs are much faster.Billingegroup/scikit-package#114