Modify MANIFEST.in to include test files in sdist for PyPI distribution #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobleesj
changed the title
|
@bobleesj quick question, is there a reason we are not simply recookiecutting Diffy.structure? |
|
No particular reason, shall we recut before |
|
And for diffpy.pdffit2, I guess the main efforts have been focusing on solving the current "issues" , so didn't attempt to modify the folder/files dramatically to avoid any unintended behavior while debugging. |
yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we PyPI release
diffpy.structure =3.2.1, we can include test files to be able to run pytest in conda-forge feedstock. conda-forge/diffpy.structure-feedstock#19(This will be obviously addressed for other packages via cookiecutting)