-
Notifications
You must be signed in to change notification settings - Fork 35
cookie release #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cookie release #63
Conversation
@sbillinge also see diffpy.srfit I made two issues #64 and #65 that we might want to fix. For #64 we want to make sure the testings are working (related to a399f18 and 15e0c07 (only change header), might relate to 7452562). For #65 I got warnings while making html, which are related to the docstrings. Another important question for this package is the licenses. I changed the file type from Other potential problems:
|
@Tieqiong I am merging this so we can move forward. the most important next step is to get the tests working with pytest, and then to set up the github workflows so we are running tests for the CI. Let's try and do that on a new PR. Please also make a news item to cover this cookie-release activity (as well as news items for each of the subsequent PRs. In general we expect one news item per PR. |
@sbillinge I also notice the unittest to pytest thing is not a problem now, as we have a conftest that should be able to do the fixture. I'll make sure it's working properly after fixing the unittest. |
How are you installing the modules before testing? |
@Sparks29032 I install the package by pip install . |
No description provided.